chore: fix labeler action globs and add auto add package labels #4946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-components-react ready! Built with commit 3f4251e https://deploy-preview-4946--carbon-components-react.netlify.com |
|
Deploy preview for the-carbon-components ready! Built with commit 3f4251e https://deploy-preview-4946--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 3f4251e |
ghost
requested review from
asudoh
approved these changes
Jan 6, 2020
There was a problem hiding this comment.
LGTM 👍 - Thanks @mattrosno! Wanted to see dry-runs on private repos done, while I imagine it's done already.
joshblack
approved these changes
Jan 6, 2020
joshblack
added a commit
to joshblack/carbon
that referenced
this pull request
Jan 6, 2020
…on-design-system#4946) * chore: fix labeler action globs and add auto add package labels * chore: make action label open PRs every 5 mins instead of on PR creation Co-authored-by: Josh Black <josh@josh.black>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the GitHub action that labels every new PR with
squad: systemso we can consolidate ZenHub workspaces. Glob syntax from actions/labeler#28 (comment).Adds package labels as well to get a better feel for "splash zone" for each PR - better see which packages are affected by the PR. New package labels will also allow us to run analysis for reporting in the future.
Update
The default action doesn't work when the PR originated from a fork, due to read-only permissions of the GH token. (See actions/labeler#12 (comment).) This new approach adds a cron job that runs every 5 minutes on the master branch to label open PRs based on file patterns: https://github.com/marketplace/actions/periodic-labeler