Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v9 theme): updated interactive values #4978

Merged
merged 3 commits into from
Jan 9, 2020
Merged

Conversation

aagonzales
Copy link
Member

interactive-02 didn't have enough contrast with Blue51 for button pairings. Interactive-03 needed to be Blue instead of Gray.

interactive-02 didn't have enough contrast with Blue51 for button pairings. Interactive-03 needed to be Blue instead of Gray.
@joshblack joshblack requested a review from a team January 8, 2020 18:56
@netlify
Copy link

netlify bot commented Jan 8, 2020

Deploy preview for the-carbon-components ready!

Built with commit d9092c5

https://deploy-preview-4978--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jan 8, 2020

Deploy preview for carbon-elements ready!

Built with commit d9092c5

https://deploy-preview-4978--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Jan 8, 2020

Deploy preview for carbon-components-react ready!

Built with commit d9092c5

https://deploy-preview-4978--carbon-components-react.netlify.com

@ghost ghost requested review from abbeyhrt and aledavila and removed request for a team January 8, 2020 22:36
Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @aagonzales!

@asudoh asudoh merged commit 5061733 into master Jan 9, 2020
@asudoh asudoh deleted the aagonzales-patch-1 branch January 9, 2020 02:19
joshblack pushed a commit to joshblack/carbon that referenced this pull request Jan 13, 2020
`interactive-02` didn't have enough contrast with `Blue51` for button
pairings. `interactive-03` needed to be Blue instead of `Gray`.
joshblack pushed a commit to joshblack/carbon that referenced this pull request Jan 14, 2020
`interactive-02` didn't have enough contrast with `Blue51` for button
pairings. `interactive-03` needed to be Blue instead of `Gray`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants