fix(uishell): add background & font color to active current links #4980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Deploy preview for the-carbon-components ready! Built with commit 8a8560c https://deploy-preview-4980--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 8a8560c |
|
Deploy preview for carbon-components-react ready! Built with commit 8a8560c https://deploy-preview-4980--carbon-components-react.netlify.com |
tw15egan
approved these changes
Jan 8, 2020
asudoh
requested review from
a team and
designertyler
and removed request for
a team
designertyler
approved these changes
Jan 9, 2020
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
Jan 13, 2020
Co-authored-by: TJ Egan <tw15egan@gmail.com>
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
Jan 14, 2020
Co-authored-by: TJ Egan <tw15egan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4842
Changelog
New
Removed
Testing / Reviewing
To test in the
carbon-components-reactdeployment --Fixed Sidenavstorya(link) node and add one of the following:aria-current="page"attribute, OR.bx--side-nav__link--currentclassThat way you can mimic an active link & see what happens when it gets an active/current ARIA or class.