Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix(dropdown): use itemToElement for selected label if not null" #5023

Merged
merged 3 commits into from
Jan 13, 2020
Merged

Revert "fix(dropdown): use itemToElement for selected label if not null" #5023

merged 3 commits into from
Jan 13, 2020

Conversation

jendowns
Copy link
Contributor

Reverts #4977

Per @joshblack's comment - #4977 (comment)

I think it should be meant only for rendering an option in a list. If we support custom rendering for the value on top of the field, we won't be able to control things like contrast or could end up with violations if people decide to put things other than text in that location.

@jendowns jendowns requested a review from a team as a code owner January 13, 2020 20:26
@ghost ghost requested review from dakahn and emyarod January 13, 2020 20:26
tw15egan
tw15egan approved these changes Jan 13, 2020
View reviewed changes
Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for quick revert 👍

@netlify
Copy link

netlify bot commented Jan 13, 2020

Deploy preview for carbon-components-react ready!

Built with commit 4d659b4

https://deploy-preview-5023--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Jan 13, 2020 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit ea224da

https://deploy-preview-5023--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Jan 13, 2020 •
edited
Loading

Deploy preview for the-carbon-components ready!

Built with commit ea224da

https://deploy-preview-5023--the-carbon-components.netlify.com

emyarod
emyarod approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@netlify
Copy link

netlify bot commented Jan 13, 2020

Deploy preview for carbon-components-react failed.

Built with commit 2e88473

https://app.netlify.com/sites/carbon-components-react/deploys/5e1cd462b17ac5000d4c1282

@netlify
Copy link

netlify bot commented Jan 13, 2020

Deploy preview for carbon-components-react failed.

Built with commit ea224da

https://app.netlify.com/sites/carbon-components-react/deploys/5e1cd8d70aeff8000883a48b

@tw15egan tw15egan merged commit 0ea9307 into carbon-design-system:master Jan 13, 2020
@jendowns jendowns deleted the revert-4977-4913_itemToElement-label branch January 14, 2020 17:24
@sanduteo95 sanduteo95 mentioned this pull request Feb 11, 2020
Closed
@emyarod emyarod mentioned this pull request Mar 25, 2020
Closed
1 task
@emyarod emyarod mentioned this pull request Aug 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tw15egan tw15egan tw15egan approved these changes

@emyarod emyarod emyarod approved these changes

@dakahn dakahn Awaiting requested review from dakahn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jendowns @emyarod @tw15egan