Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DAP to v2.0.6 #5041

Merged
merged 5 commits into from
Jan 15, 2020
Merged

Update DAP to v2.0.6 #5041

merged 5 commits into from
Jan 15, 2020

Conversation

dakahn
Copy link
Contributor

@dakahn dakahn commented Jan 14, 2020

Updating DAP to latest. v2.0.6

Apparently there are settings in jest that override settimeout behavior, which basically causes any usage of settimeout to hang (supposed to be for testing ticks, but has collateral side effects). Shouldn't have been irregular on your end, but worth a shot. This version will skip not use the settimeout approach to getting out of the stack when in jest environments.

❤️

To test

in root folder run yarn test and make sure DAP is being run without unexpected error.

@dakahn dakahn requested a review from a team as a code owner January 14, 2020 23:26
@netlify
Copy link

netlify bot commented Jan 14, 2020

Deploy preview for the-carbon-components ready!

Built with commit 8502481

https://deploy-preview-5041--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jan 14, 2020

Deploy preview for carbon-components-react ready!

Built with commit 8502481

https://deploy-preview-5041--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Jan 14, 2020

Deploy preview for carbon-elements ready!

Built with commit 8502481

https://deploy-preview-5041--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Jan 14, 2020

Deploy preview for the-carbon-components ready!

Built with commit 9d028f9

https://deploy-preview-5041--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jan 14, 2020

Deploy preview for carbon-components-react failed.

Built with commit 9d028f9

https://app.netlify.com/sites/carbon-components-react/deploys/5e1e4e358e959500078e00f0

@netlify
Copy link

netlify bot commented Jan 14, 2020

Deploy preview for carbon-elements failed.

Built with commit 9d028f9

https://app.netlify.com/sites/carbon-elements/deploys/5e1e4e35021d2f00080441ca

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @dakahn!

@asudoh asudoh merged commit 3adcf8a into carbon-design-system:master Jan 15, 2020
joshblack pushed a commit to joshblack/carbon that referenced this pull request Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants