feat(Grid): enable zero span columns #5052
Conversation
|
Deploy preview for the-carbon-components ready! Built with commit e7f03b1 https://deploy-preview-5052--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit e7f03b1 |
|
Deploy preview for carbon-components-react failed. Built with commit e7f03b1 https://app.netlify.com/sites/carbon-components-react/deploys/5e262b5158e14f000ae152ea |
There was a problem hiding this comment.
Looks basically good, wanted to see what @joshblack thinks. Great to have some clarification of for loop starting -1 (Is it some kind of Sass trick?). Thanks @zachhardesty7!
|
@asudoh Honestly, I wrote this quite a while ago as a feature of the (upcoming) React Grid components. I have no idea why I put |
asudoh
requested review from
a team and
aagonzales
and removed request for
a team
Adds functionality requested in (#2435) with more convenient syntax.
Since Grid components may often have their classes added programatically, enabling the use of span "0" simplifies the code and improves readability. From an English language syntax perspective, content "spanning 0 columns" makes sense in a similar way as content with a "width of 0." Additionally, several other major libraries support this notation.
Changelog
New
.bx--col-0that setsdisplay: noneon a given columnTesting / Reviewing
The example docs now include a demonstration of the class in action!