fix(ui-shell): remove role banner from header ui-shell #5077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for the-carbon-components ready! Built with commit 74f6015 https://deploy-preview-5077--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 74f6015 |
|
Deploy preview for carbon-components-react ready! Built with commit 74f6015 https://deploy-preview-5077--carbon-components-react.netlify.com |
abbeyhrt
approved these changes
Jan 17, 2020
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
Jan 23, 2020
…-system#5077) Co-authored-by: Abbey Hart <abbeyhrt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
After running DAP on
https://www.ibm.com/design/thinkingwe noticed the following violation was introduced by the Carbon UI Shell: https://aat.w3ibm.mybluemix.net/token/07b25738-c5c6-4479-ad20-bead3e1aac6b/09148427-a9bf-417b-8d67-972cfa453cd3/latest///doc/w3/help/en-US/idhi_accessibility_check_g1146.htmlChangelog
New
role=banneron a header: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/Banner_roleChanged
role=banneron the UI ShellRemoved
role=banneron the UI ShellTesting / Reviewing
yarn testand make sure all relevant tests pass. :)