fix(TableBatchActions): ensure hidden action bar un-focusable #5081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change prevents hidden table batch action bar contents from being focused. Fixes carbon-design-system#5049.
|
Deploy preview for the-carbon-components ready! Built with commit 6f1f27d https://deploy-preview-5081--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 6f1f27d |
|
Deploy preview for carbon-components-react ready! Built with commit 6f1f27d https://deploy-preview-5081--carbon-components-react.netlify.com |
tw15egan
approved these changes
Jan 17, 2020
emyarod
reviewed
Jan 17, 2020
emyarod
approved these changes
Jan 20, 2020
emyarod
added
status: failing CI 🙅♂️
and removed
status: one more review 👀
status: ready for review 👀
labels
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
Jan 23, 2020
…-design-system#5081) This change prevents hidden table batch action bar contents from being focused. Fixes carbon-design-system#5049.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change prevents hidden table batch action bar contents from being
focused.
Fixes #5049.
Changelog
Changed
tabIndexfor buttons in hidden batch action bar.Testing / Reviewing
Testing should make sure table batch action bar is not broken.