Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(breadcrumbs): add spread attribute to allow additional attrs on root node #5108

Merged
merged 4 commits into from
Jan 21, 2020
Merged

feat(breadcrumbs): add spread attribute to allow additional attrs on root node #5108

merged 4 commits into from
Jan 21, 2020

Conversation

jendowns
Copy link
Contributor

Closes #5107

Changelog

New

  • add a spread attribute so that users an pass in additional attributes, like id

@jendowns jendowns requested a review from a team as a code owner January 20, 2020 21:11
@ghost ghost requested review from emyarod and joshblack January 20, 2020 21:11
@joshblack
Copy link
Contributor

One quick note for folks merging in, we should do fix -> feat since it's adding functionality 👍

@jendowns jendowns changed the title fix(breadcrumbs): add spread attribute to allow additional attrs on root node feat(breadcrumbs): add spread attribute to allow additional attrs on root node Jan 20, 2020
@netlify
Copy link

netlify bot commented Jan 20, 2020 •
edited
Loading

Deploy preview for the-carbon-components ready!

Built with commit 931d55e

https://deploy-preview-5108--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jan 20, 2020 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit 931d55e

https://deploy-preview-5108--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Jan 20, 2020 •
edited
Loading

Deploy preview for carbon-components-react failed.

Built with commit 931d55e

https://app.netlify.com/sites/carbon-components-react/deploys/5e264b8774ddab00083898c7

tw15egan
tw15egan approved these changes Jan 21, 2020
View reviewed changes
Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asudoh asudoh merged commit e4d0723 into carbon-design-system:master Jan 21, 2020
joshblack pushed a commit to joshblack/carbon that referenced this pull request Jan 23, 2020
@jendowns @joshblack
fix(breadcrumbs): add spread attribute to root node (carbon-design-sy…
cb2a1ec 
…stem#5108)
@joshblack joshblack mentioned this pull request Jan 23, 2020
Closed
@joshblack joshblack mentioned this pull request Jan 31, 2020
Closed
@joshblack joshblack mentioned this pull request Feb 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@tw15egan tw15egan tw15egan approved these changes

@abbeyhrt abbeyhrt abbeyhrt approved these changes

@emyarod emyarod Awaiting requested review from emyarod

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Breadcrumbs]: allow React component to accept additional attributes
5 participants
@jendowns @joshblack @tw15egan @abbeyhrt @asudoh