Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Tabs): allow keyboard event defaults #5124

Merged
merged 2 commits into from
Jan 22, 2020
Merged

fix(Tabs): allow keyboard event defaults #5124

merged 2 commits into from
Jan 22, 2020

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Jan 21, 2020

Ref #4784 (comment)

This PR allows default keyboard event behavior in the non-mobile Tabs component

Changelog

Removed

  • event.preventDefault call

Testing / Reviewing

Place a tabbable element in the tab content panel and navigate to it using the keyboard from the tabs list, or scroll on a page with overflow using the arrow keys while a tab is focused

@emyarod emyarod requested a review from a team as a code owner January 21, 2020 21:54
@ghost ghost requested review from dakahn and joshblack January 21, 2020 21:54
@emyarod emyarod mentioned this pull request Jan 21, 2020
Merged
@emyarod emyarod force-pushed the 4784-remove-tab-keyboard-handler-prevent-default branch from 8c12037 to 19e73d8 Compare January 21, 2020 21:57
@netlify
Copy link

netlify bot commented Jan 21, 2020

Deploy preview for the-carbon-components ready!

Built with commit 8c12037

https://deploy-preview-5124--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jan 21, 2020

Deploy preview for carbon-elements failed.

Built with commit 8c12037

https://app.netlify.com/sites/carbon-elements/deploys/5e277300df4f6a000c00ed9c

@netlify
Copy link

netlify bot commented Jan 21, 2020

Deploy preview for carbon-components-react failed.

Built with commit 8c12037

https://app.netlify.com/sites/carbon-components-react/deploys/5e27730007a91d0008e8428b

@netlify
Copy link

netlify bot commented Jan 21, 2020 •
edited
Loading

Deploy preview for carbon-components-react failed.

Built with commit fa451c8

https://app.netlify.com/sites/carbon-components-react/deploys/5e279299a1811b0008e29eb8

@netlify
Copy link

netlify bot commented Jan 21, 2020 •
edited
Loading

Deploy preview for carbon-elements failed.

Built with commit fa451c8

https://app.netlify.com/sites/carbon-elements/deploys/5e279299462b4c0008b297d7

@netlify
Copy link

netlify bot commented Jan 21, 2020 •
edited
Loading

Deploy preview for the-carbon-components ready!

Built with commit fa451c8

https://deploy-preview-5124--the-carbon-components.netlify.com

asudoh
asudoh approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @emyarod!

tw15egan
tw15egan approved these changes Jan 22, 2020
View reviewed changes
Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ✅

@asudoh asudoh merged commit 79cdcbc into carbon-design-system:master Jan 22, 2020
@emyarod emyarod deleted the 4784-remove-tab-keyboard-handler-prevent-default branch January 23, 2020 01:57
@emyarod emyarod mentioned this pull request Jan 23, 2020
Closed
joshblack pushed a commit to joshblack/carbon that referenced this pull request Jan 23, 2020
@emyarod @joshblack
fix(Tabs): allow keyboard event defaults (carbon-design-system#5124)
cd62e62
@joshblack joshblack mentioned this pull request Jan 23, 2020
Closed
@joshblack joshblack mentioned this pull request Jan 31, 2020
Closed
@joshblack joshblack mentioned this pull request Feb 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asudoh asudoh asudoh approved these changes

@tw15egan tw15egan tw15egan approved these changes

@dakahn dakahn Awaiting requested review from dakahn

@joshblack joshblack Awaiting requested review from joshblack

Assignees
No one assigned
Labels
status: one more review 👀 status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emyarod @asudoh @tw15egan