fix(tile): adds onChange call to handlers in selectable tile #5156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for the-carbon-components ready! Built with commit 0691601 https://deploy-preview-5156--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react failed. Built with commit 0691601 https://app.netlify.com/sites/carbon-components-react/deploys/5e2b8f240d31290008fca90f |
|
Deploy preview for carbon-elements ready! Built with commit 0691601 |
tw15egan
approved these changes
Jan 24, 2020
Co-Authored-By: Akira Sudoh <asudoh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5130
This PR adds a call to
onChangeonhandleClickandhandleKeydownso that it's called when people select a tile through the traditional methods. This removes theisInputcheck fromhandleClickbecause the input is a 1x1 square behind the label and can not be clicked. It also adds a test to make sure theonChangehandler is calledChangelog
New
onChangepropChanged
onChangecall to handlersRemoved
isInputfromhandleClickTesting / Reviewing
Pull down the PR, add a console.log to the onChange prop and verify that onChange is called when a tile is selected.