feat(react): add support for rollup in bundles #5185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
FYI @vpicone |
|
Deploy preview for the-carbon-components ready! Built with commit 7c5c391 https://deploy-preview-5185--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 7c5c391 |
|
Deploy preview for carbon-components-react failed. Built with commit 7c5c391 https://app.netlify.com/sites/carbon-components-react/deploys/5e3076cf41084a000cf089be |
|
@joshblack nice! When messing around with typescript this seemed like a pretty necessary move. |
|
@joshblack Could you go over the rollup config stuff with me? Config files are a complete mystery to me |
abbeyhrt
suggested changes
Jan 27, 2020
…k/carbon into feat/add-rollup-bundle-to-react
|
@abbeyhrt updated! Thanks for the catch |
abbeyhrt
approved these changes
Jan 28, 2020
This was referenced Feb 25, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add in support for creating ESM, CommonJS, and UMD bundles through a single rollup config. This change also keeps support for importing files directing to maintain backwards-compatibility. As a result, these changes generate (or maintain) the following bundles with rollup:
es/index.jslib/index.jsumd/carbon-components-react.jsumd/carbon-components-react.min.jsChangelog
New
Changed
carbon-components-reactto use rollup for bundling ESM, CommonJS, and UMDRemoved