feat(notification): add info icon to notification #5203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
tw15egan
changed the title
|
Deploy preview for the-carbon-components ready! Built with commit fdca041 https://deploy-preview-5203--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react failed. Built with commit fdca041 https://app.netlify.com/sites/carbon-components-react/deploys/5e31edb4e954dd00088706ee |
|
Deploy preview for carbon-elements failed. Built with commit fdca041 https://app.netlify.com/sites/carbon-elements/deploys/5e31edb480c30e0009f53f9f |
asudoh
approved these changes
Jan 29, 2020
asudoh
requested review from
a team and
aagonzales
and removed request for
a team
aagonzales
requested review from
jeanservaas
and removed request for
aagonzales
aledavila
approved these changes
Jan 29, 2020
tw15egan
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
status: visual review 🔍
labels
This was referenced Feb 25, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5190
This adds in the
infoicon to all variations ofNotification, vanilla and react.Changelog
New
infoicon to all variations ofNotificationChanged
Testing / Reviewing
Check that the
infonotification shows in vanilla and react