Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data-table): remove hover styles from thead checkbox #5209

Merged
merged 7 commits into from
Jan 30, 2020

Conversation

tw15egan
Copy link
Member

Closes #4971

Removes inadvertent hover styles from the "Select All" checkbox.

Changelog

Changed

  • Increased specificity to only add hover styles to checkboxes inside the tbody

Testing / Reviewing

Hover over the thead checkbox ("Select All") and make sure no hover styles appear.

@netlify
Copy link

netlify bot commented Jan 29, 2020

Deploy preview for the-carbon-components ready!

Built with commit 92466f5

https://deploy-preview-5209--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jan 29, 2020

Deploy preview for carbon-components-react failed.

Built with commit 92466f5

https://app.netlify.com/sites/carbon-components-react/deploys/5e3366b66bc90d0008faf46e

@netlify
Copy link

netlify bot commented Jan 29, 2020

Deploy preview for carbon-elements ready!

Built with commit 92466f5

https://deploy-preview-5209--carbon-elements.netlify.com

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @tw15egan!

@asudoh asudoh requested review from a team and designertyler and removed request for a team January 29, 2020 21:25
Copy link
Contributor

@dakahn dakahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Checked on Windows 10 in Firefox latest

@asudoh asudoh merged commit 7e299c0 into carbon-design-system:master Jan 30, 2020
@tw15egan tw15egan deleted the remove-data-table-hover branch April 28, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header with checkbox in DataTable has a hover state
5 participants