fix(data-table): fix row sizing with overflow menu #5292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit 2068f81 |
|
Deploy preview for carbon-components-react ready! Built with commit 2068f81 https://deploy-preview-5292--carbon-components-react.netlify.com |
asudoh
requested review from
a team and
jeanservaas
and removed request for
a team
|
@tw15egan looks like react deploy failed. |
|
@jeanservaas should be up now 👍 |
|
@tw15egan I don't think this needs to be addressed in this PR but it seems like the DataTable |
abbeyhrt
approved these changes
Feb 7, 2020
joshblack
approved these changes
Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4586
Adds some negative margins so that
OverflowMenudoes not affect row sizing. Can be seen in our Storybook: https://react.carbondesignsystem.com/?path=/story/datatable--with-overflow-menuSolution found here: carbon-design-system/carbon-components-angular#886 (comment)
Changelog
New
Testing / Reviewing
Make sure Overflow Menu is positioned properly on all size Data Tables, and does not increase the row height