Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(react): update storybook to re-enable theming panels #5332

Merged
merged 3 commits into from
Feb 13, 2020
Merged

chore(react): update storybook to re-enable theming panels #5332

merged 3 commits into from
Feb 13, 2020

Conversation

joshblack
Copy link
Contributor

Closes #5331

Update storybook config to remove dynamic import and update call signature for addons registration.

Changelog

New

Changed

  • Update how our custom addon is registered

Removed

Testing / Reviewing

  • Verify the netlify preview includes the theme and type panels
  • Pull down locally and verify:
    • Running yarn storybook does not include the theme and type panels
    • Running CARBON_REACT_STORYBOOK_USE_CUSTOM_PROPERTIES=true yarn storybook does include the theme and type panels

@joshblack joshblack requested a review from a team as a code owner February 12, 2020 18:53
@ghost ghost requested review from aledavila and dakahn February 12, 2020 18:54
@netlify
Copy link

netlify bot commented Feb 12, 2020 •
edited
Loading

Deploy preview for carbon-elements failed.

Built with commit 6d7396d

https://app.netlify.com/sites/carbon-elements/deploys/5e45696301db2f00087d69bb

@netlify
Copy link

netlify bot commented Feb 12, 2020 •
edited
Loading

Deploy preview for carbon-components-react ready!

Built with commit 6d7396d

https://deploy-preview-5332--carbon-components-react.netlify.com

@joshblack
Copy link
Contributor Author

cc @aagonzales if you wanted to double-check!

aagonzales
aagonzales reviewed Feb 12, 2020
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's alive again!! Awesome, thank you.

aagonzales
aagonzales approved these changes Feb 12, 2020
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops got too excited and selected the wrong thing

asudoh
asudoh approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @joshblack!

@joshblack joshblack merged commit 9105472 into carbon-design-system:master Feb 13, 2020
@joshblack joshblack deleted the 5331-re-enable-theming-panels branch February 13, 2020 16:22
@joshblack joshblack mentioned this pull request Feb 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asudoh asudoh asudoh approved these changes

@aagonzales aagonzales aagonzales approved these changes

@aledavila aledavila aledavila approved these changes

@dakahn dakahn Awaiting requested review from dakahn

@emyarod emyarod Awaiting requested review from emyarod

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable theming panels in storybook
4 participants
@joshblack @asudoh @aagonzales @aledavila