Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(combobox/text-input): add svg top positioning for IE11 #5362

Merged
merged 13 commits into from
Feb 18, 2020
Merged

fix(combobox/text-input): add svg top positioning for IE11 #5362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
efdc6e7
fix(text-input): add top attribute to invalid svg for ie11
dakahn Feb 12, 2020
79009b6
fix(combobox): add css reset
dakahn Feb 14, 2020
1dc212c
fix(combobox): add top positioning for ie11 fix
dakahn Feb 14, 2020
9ef2bd7
Merge branch 'master' into 5335-ie11-svg-bugs
tw15egan Feb 17, 2020
d171297
Merge branch 'master' into 5335-ie11-svg-bugs
joshblack Feb 17, 2020
a2f8001
fix(listbox): add non-magic number positioning solution for ei11
dakahn Feb 17, 2020
ababe25
fix(listbox/text-input): add correct comment style
dakahn Feb 17, 2020
cf59e04
Merge branch 'master' into 5335-ie11-svg-bugs
joshblack Feb 17, 2020
9af9825
Merge branch 'master' into 5335-ie11-svg-bugs
joshblack Feb 17, 2020
55c9a58
Merge branch 'master' into 5335-ie11-svg-bugs
dakahn Feb 18, 2020
d465855
Merge branch 'master' into 5335-ie11-svg-bugs
asudoh Feb 18, 2020
7983ae3
Merge branch 'master' into 5335-ie11-svg-bugs
asudoh Feb 18, 2020
4d68562
Merge branch 'master' into 5335-ie11-svg-bugs
tw15egan Feb 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/components/src/components/combo-box/_combo-box.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
@import '../../globals/scss/vars';
@import '../../globals/scss/vendor/@carbon/elements/scss/import-once/import-once';
@import '../list-box/list-box';
@import '../../globals/scss/css--reset';

/// Combo box styles
/// @access private
Expand Down
3 changes: 3 additions & 0 deletions packages/components/src/components/list-box/_list-box.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,9 @@ $list-box-menu-width: rem(300px);
.#{$prefix}--list-box__selection {
position: absolute;
right: rem(33px); // to preserve .5rem space between icons according to spec
// top/transform used to center invalid icon in IE11
top: 50%;
transform: translateY(-50%);
display: flex;
justify-content: center;
align-items: center;
Expand Down
3 changes: 3 additions & 0 deletions packages/components/src/components/text-input/_text-input.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,9 @@
.#{$prefix}--text-input__invalid-icon {
position: absolute;
right: $carbon--spacing-05;
// top/transform used to center invalid icon in IE11
top: 50%;
transform: translateY(-50%);
fill: $support-01;
}

Expand Down