fix: Prevent Tooltip setState call if not open #5363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit 187df6e |
|
Deploy preview for carbon-components-react ready! Built with commit 187df6e https://deploy-preview-5363--carbon-components-react.netlify.com |
|
@asudoh it looks like this is for tooltip rather than overflow menu and should be a port of carbon-design-system/carbon-components-react#2424 right? |
emyarod
approved these changes
Feb 17, 2020
joshblack
approved these changes
Feb 17, 2020
|
@grommett My apologies for confusing this one with the other! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents the
handleClickOutsidefrom callingsetStateif the ToolTip is already closed. This same code change was merged in the previous version of Carbon React.The reason for this check is that, at scale, these calls create real performance issues.
Our app has over 1,000
<Tooltip />s. Each of these<Tooltip />s callssetState({open: false})for any click in the UI. The unnecessary calls tosetStatemakes toggling radio buttons and opening Modals very, very slow. Up to two seconds in some cases in our UI. After adding this check the UI behaves normally.Changelog
Changed
handleClickOutsidemethod.Testing / Reviewing
Below is a performance screenshot with current behavior.
