Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toggle): prevent text from wrapping #5393

Merged
merged 6 commits into from
Feb 20, 2020

Conversation

tw15egan
Copy link
Member

Closes #5392

Prevent toggle label text from wrapping

Screen Shot 2020-02-19 at 11 32 26 AM

Changelog

Changed

  • Add white-space: nowrap to prevent text wrapping

Testing / Reviewing

Add 已啟 to the Toggle label and ensure the label does not wrap to the next line

@tw15egan tw15egan requested a review from a team as a code owner February 19, 2020 10:33
@ghost ghost requested review from dakahn and joshblack February 19, 2020 10:33
@tw15egan tw15egan requested review from a team and designertyler and removed request for a team February 19, 2020 10:34
@netlify
Copy link

netlify bot commented Feb 19, 2020

Deploy preview for carbon-elements ready!

Built with commit 7ce5103

https://deploy-preview-5393--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Feb 19, 2020

Deploy preview for carbon-components-react ready!

Built with commit 7ce5103

https://deploy-preview-5393--carbon-components-react.netlify.com

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @tw15egan!

Copy link
Contributor

@designertyler designertyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asudoh asudoh merged commit a84e31c into carbon-design-system:master Feb 20, 2020
@tw15egan tw15egan deleted the toggle-text-fix branch April 28, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toggle text breaks to new lines
7 participants