docs(combobox): remove custom text input handling story #5431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-elements failed. Built with commit ffeb892 https://app.netlify.com/sites/carbon-elements/deploys/5e5549a33c9f1a0007c3468e |
|
Deploy preview for carbon-components-react failed. Built with commit ffeb892 https://app.netlify.com/sites/carbon-components-react/deploys/5e5549a3e1c33c000a5c3c7e |
joshblack
approved these changes
Feb 25, 2020
tw15egan
approved these changes
Feb 25, 2020
aledavila
approved these changes
Feb 25, 2020
|
Deploy preview for carbon-components-react ready! Built with commit da30e73 https://deploy-preview-5431--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit da30e73 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5399
This PR removes the
custom text input handlingstory for Combobox from Storybook since it was a broken example. The problem is that theonInputChangefunction that was editing the options gets calledonBlur, making the selection duplicate itself. This could be fixed but would either need a weird workaround in the story or to change the component itself by preventing theonBlurfrom callingonInputChangebut that could mess with the end users. Since I don't think this is an essential example, I decided to remove it.Changelog
Removed
custom text input handlingstoryTesting / Reviewing
Decide whether or not removing the story is the best solution here!