fix(ListBox): enable drawer animation #5810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds was-missing animation to list boxes' drawers. Fixes carbon-design-system#2697.
asudoh
requested review from
emyarod,
a team and
jeanservaas
and removed request for
a team
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit c63c08d |
|
Deploy preview for carbon-components-react ready! Built with commit c63c08d https://deploy-preview-5810--carbon-components-react.netlify.com |
tw15egan
approved these changes
Apr 6, 2020
emyarod
approved these changes
Apr 6, 2020
asudoh
added
status: ready to merge 🎉
and removed
status: merge conflict 🚫
status: visual review 🔍
labels
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
Apr 16, 2020
This change adds was-missing animation to list boxes' drawers. Fixes carbon-design-system#2697. Co-authored-by: TJ Egan <tw15egan@gmail.com>
joshblack
pushed a commit
that referenced
this pull request
Apr 21, 2020
This change adds was-missing animation to list boxes' drawers. Fixes #2697. Co-authored-by: TJ Egan <tw15egan@gmail.com>
This was referenced Apr 23, 2020
|
Should we be setting |
|
See #5949 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Please use gear icon - "Hide whitespace changes" for reviewing)
This change adds was-missing animation to list boxes' drawers.
Fixes #2697.
Changelog
New
Testing / Reviewing
Testing should make sure
<ComboBox>,<Dropdown>,<MultiSelect>are not broken.