feat(icons): re-enable SVGO optimizations for icons #5814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit 67d7e7e |
|
Deploy preview for carbon-components-react ready! Built with commit 67d7e7e https://deploy-preview-5814--carbon-components-react.netlify.com |
|
Would it be possible to also run this on the SVG's in the |
emyarod
reviewed
Apr 6, 2020
asudoh
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We turned off this setting back in #5603 but have since transitioned to using the original SVG assets instead of the generated JS for rendering icons in a Sketch plugin. As a result, this PR re-enables the optimizations that were causing issues in Sketch but still render fine in a browser.
Changelog
New
Changed
Removed