fix(dropdown): fix redundant programmatic focusable element #5818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change eliminates redundant programmatic focusable element from vanilla dropdown. Fixes carbon-design-system#4640.
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit 3e82d59 |
|
Deploy preview for carbon-components-react ready! Built with commit 3e82d59 https://deploy-preview-5818--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 9b6cc68 |
|
Deploy preview for carbon-components-react ready! Built with commit 9b6cc68 https://deploy-preview-5818--carbon-components-react.netlify.com |
emyarod
approved these changes
Apr 7, 2020
joshblack
approved these changes
Apr 8, 2020
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
Apr 16, 2020
…esign-system#5818) This change eliminates redundant programmatic focusable element from vanilla dropdown. Fixes carbon-design-system#4640.
joshblack
pushed a commit
that referenced
this pull request
Apr 21, 2020
This change eliminates redundant programmatic focusable element from vanilla dropdown. Fixes #4640.
This was referenced Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change eliminates redundant programmatic focusable element from vanilla dropdown.
Fixes #4640.
Changelog
New
Testing / Reviewing
Testing should make sure vanilla dropdown is not broken.