fix(DataTable): ignore disabled rows on table select all #5840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
emyarod
force-pushed
the
5832-ignore-disabled-rows-during-select-all
branch
from
0b98a18
to
0b5c8d2
Compare
|
Deploy preview for carbon-elements ready! Built with commit 0b98a18 |
|
Deploy preview for carbon-components-react ready! Built with commit 0b98a18 https://deploy-preview-5840--carbon-components-react.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit 3f1441f https://deploy-preview-5840--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 3f1441f |
tw15egan
approved these changes
Apr 9, 2020
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
Apr 16, 2020
joshblack
pushed a commit
that referenced
this pull request
Apr 21, 2020
This was referenced Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5832
Ref #4430
This PR ignores disabled rows when interacting with the
<TableSelectAll>checkboxTesting / Reviewing
Confirm that table row selection logic is correct when a data table contains disabled rows (checked, unchecked, and indeterminate states) as well as when no rows are disabled. Also ensure that filtering rows works as intended (ref #2496)