fix(checkbox): match label spacing in skeleton #5847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
joshblack
approved these changes
Apr 10, 2020
|
Deploy preview for carbon-elements ready! Built with commit 55f1497 |
|
Deploy preview for carbon-components-react ready! Built with commit 55f1497 https://deploy-preview-5847--carbon-components-react.netlify.com |
dakahn
approved these changes
Apr 10, 2020
asudoh
requested review from
a team and
designertyler
and removed request for
a team
designertyler
approved these changes
Apr 13, 2020
emyarod
force-pushed
the
checkbox-skeleton-spacing
branch
from
639c484
to
1013c5b
Compare
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
Apr 16, 2020
joshblack
pushed a commit
that referenced
this pull request
Apr 21, 2020
This was referenced Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the checkbox skeleton to match the label spacing from #5463
Testing / Reviewing
Ensure the checkbox skeleton is visually correct