fix(CodeSnippet): observe resize #5854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes `<CodeSnippet>` observes for the resize of its top-level element so the visibility of Show More button can be updated upon the up-to-date element size. Fixes carbon-design-system#5819.
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit e4409c9 |
|
Deploy preview for carbon-components-react ready! Built with commit e4409c9 https://deploy-preview-5854--carbon-components-react.netlify.app |
asudoh
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
dakahn
approved these changes
Apr 16, 2020
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
Apr 23, 2020
This change makes `<CodeSnippet>` observes for the resize of its top-level element so the visibility of Show More button can be updated upon the up-to-date element size. Fixes carbon-design-system#5819. Co-authored-by: TJ Egan <tw15egan@gmail.com>
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
Apr 23, 2020
This change makes `<CodeSnippet>` observes for the resize of its top-level element so the visibility of Show More button can be updated upon the up-to-date element size. Fixes carbon-design-system#5819. Co-authored-by: TJ Egan <tw15egan@gmail.com>
joshblack
pushed a commit
that referenced
this pull request
Apr 23, 2020
This change makes `<CodeSnippet>` observes for the resize of its top-level element so the visibility of Show More button can be updated upon the up-to-date element size. Fixes #5819. Co-authored-by: TJ Egan <tw15egan@gmail.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes
<CodeSnippet>observes for the resize of its top-level element so the visibility of Show More button can be updated upon the up-to-date element size.Fixes #5819.
Changelog
Changed
useLayoutEffect()withuseResizeObserver()to watch for the change in element size to show/hide Show More button.Testing / Reviewing
Testing should make sure
<CodeSnippet>is not broken.