Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ui-shell): add JSDoc annotations #5862

Merged
merged 4 commits into from
Apr 15, 2020

Conversation

asudoh
Copy link
Contributor

@asudoh asudoh commented Apr 15, 2020

Closes #5668.

Changelog

New

  • JSDoc annotations for vanilla UI shell code.

@asudoh asudoh requested review from emyarod and a team April 15, 2020 09:42
@ghost ghost requested review from tw15egan and removed request for a team April 15, 2020 09:42
@netlify
Copy link

netlify bot commented Apr 15, 2020

Deploy preview for carbon-elements ready!

Built with commit f3a9e28

https://deploy-preview-5862--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Apr 15, 2020

Deploy preview for carbon-components-react ready!

Built with commit f3a9e28

https://deploy-preview-5862--carbon-components-react.netlify.app

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, just a few small changes

Co-Authored-By: emyarod <emyarod@users.noreply.github.com>
@tw15egan tw15egan requested a review from a team as a code owner April 15, 2020 18:09
@ghost ghost requested a review from aledavila April 15, 2020 18:09
Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ✅

@asudoh asudoh merged commit 63912e6 into carbon-design-system:master Apr 15, 2020
@asudoh asudoh deleted the jsdoc-shell branch April 15, 2020 21:49
@asudoh
Copy link
Contributor Author

asudoh commented Apr 15, 2020

Thanks @emyarod for your feedback and @tw15egan for applying the correction!

joshblack pushed a commit to joshblack/carbon that referenced this pull request Apr 16, 2020
joshblack pushed a commit that referenced this pull request Apr 21, 2020
This was referenced Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI-shell Header - Vanilla JS
5 participants