feat: icons-new-march-april #5888
Conversation
Submitting new and updated UI icons from March and April all updates and additions approved by BXD 115 net new icons 13 updated icons updated categories.yml with additions updated ui-icon-master.ai with additions and updates
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit 918c559 |
|
Deploy preview for carbon-components-react ready! Built with commit 918c559 https://deploy-preview-5888--carbon-components-react.netlify.app |
|
Thanks for this @conradennis! Seems like |
|
@joshblack thanks for the heads up. It's included in the categories.yml file under organization > data |
|
@joshblack When will this release? And @conradennis assuming all these beauties have been updated in the master Ai file for download? This is a great batch of icons! |
|
Hey @mjabbink! 👋 These should be in our 10.12 release which is targeted for May 5th. Link to release schedule |
|
@joshblack That is a long period of time. What can we do to get icons and pictograms released on a more fluid release schedule? |
|
@mjabbink, unfortunately, our release schedule is time-based to help teams plan for when to pick up updates so we align to that schedule posted in the previous comment. In the past, we did releases as things got contributed and that ended up creating too much noise for teams to update reliably so we switched to this time-based schedule as a result. |
|
is this because of the Sketch kit? Is there anything to prevent the release of the icons to the icon library pages in IDL and Carbon sites? |
|
@mjabbink the biggest reason is for the packages themselves, each release comes with a new version and while certain updates get pulled in automatically others are still a manual upgrade for teams. For the website, I believe it'll reflect our latest version of Carbon so that folks aren't referencing that isn't available yet in code. For the IDL site, we could definitely figure out how it can consume the nightly builds for icons to try and tackle this sooner 👍 |
|
@joshblack It would be great if we can get the new icons released on IDL. Should I get the Aux squad to tackle? |
|
@joshblack @conradennis Can we get these merged? |
|
@joshblack I see merged but the icons are not in the libraries in IDL or Carbon sites. Can we get this live in IDL because I think you’re waiting to get these into the Sketch kit? |
|
@mjabbink I believe they're available in the latest deployed site (https://carbondesignsystem.now.sh/guidelines/icons/library) but carbondesignsystem.com hasn't been swapped over yet as we noticed that the pictograms weren't rendering (https://carbondesignsystem.now.sh/guidelines/pictograms/library) Merged in a fix today, waiting for the slider fix (in PR) and then we're going to do a hotfix with both 👍 |
|
thanks @joshblack Not seeing them in the IDL library? |
|
also seeing dashes show up in the naming now in any new Icons or Pictograms.
———— |
|
Friendly naming now showing up in the new additions. |
|
These need to show up in the IDL Library. |
|
These need to be in the IDL l=icon library Monday please. I cannot ask about this again. |
|
@mjabbink there may be some process confusion with this work. Contributors on this PR and this project do not work with the IDL site and do not know how it gets updated or deployed. We ship the icon packages that projects like IDL or carbon can bring in. This specific PR was included in the v10.12 release of the packages which was released on May 14th and are available for teams to use. |
|
@vpicone please have someone on the Aux team take care of this. We need to get the workflow sorted for icon and pictogram additions. They need to also get added to the IDL library at the same time they get added to the Carbon library |
|
@vpicone @joshblack lets sync up to figure out how we can make sure icons get updated in sync on IDl/Carbon website. |
|
@joshblack I was not clear on the process so apologize for any revealed frustration on my part. Looks like Alison and Vince will sort out the flow. |
Submitting new and updated UI icons from March and April
all updates and additions approved by BXD
115 net new icons
13 updated icons
updated categories.yml with additions
updated ui-icon-master.ai with additions and updates
Closes #4053
@laurenmrice
[Icons] Checkmark and Indeterminate icon should have editable inner fill in sketch
Changelog
New
Changed