feat(number-input): respect min, max, and step attributes #5906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
|
Deploy preview for carbon-elements ready! Built with commit 290fca5 |
|
Deploy preview for carbon-components-react ready! Built with commit 290fca5 https://deploy-preview-5906--carbon-components-react.netlify.app |
asudoh
reviewed
Apr 21, 2020
There was a problem hiding this comment.
Great work 🎉! - Just one thing, would you be able to add tests for mix/max capping with empty - Thanks @emyarod!<input>? (e.g. for hitting backspace key)
Update: I now realized that the changed logic won't be applied for such scenario - My apologies.
asudoh
approved these changes
Apr 22, 2020
emyarod
force-pushed
the
5885-number-input-min-max-step
branch
from
f1fc069
to
d5aee2e
Compare
tw15egan
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5885
This PR adds support for the
min,max, andstepattributes in the number input componentTesting / Reviewing
Confirm the
min,max, andstepvalues are respected when incrementing and decrementing the number input