feat(tag): add high-contrast type #5910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit 86ba77c |
|
Deploy preview for carbon-components-react ready! Built with commit 86ba77c https://deploy-preview-5910--carbon-components-react.netlify.app |
asudoh
requested review from
a team and
designertyler
and removed request for
a team
emyarod
approved these changes
Apr 23, 2020
|
@emyarod Sure thing. Fix is pushed! |
|
Would it be better to use the |
|
@designertyler Good point, haven't thought about that. |
2 tasks
joshblack
approved these changes
Apr 27, 2020
|
@designertyler anything else you can think of after the updates from @janhassel using the inverse tokens? 👀 |
designertyler
approved these changes
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the recent work on bringin over the normal tag colors in filter tags, the default dark-gray appearance is not supported anymore. However, there are situations where a higher contrast than the normal gray tag color is needed. In fact, the multi-select component uses a custom background-color override since it sits inside of an input element (and therefore usually on a light gray background).
This PR is a proposal on introducing a "high-contrast" tag type (name is not set in stone) which essentially inverts the default gray appearance from light and dark themes.
So, in white/g10 it will look like a default tag in g90/g100 and in g90/g100 it will look like a default tag in white/g10.
Changelog
New
high-contrasthigh-contrasttype to React componentTesting / Reviewing
Verify new tag type on react storybook.