fix(components): fix for RHL #5929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes the issue that comes with unmatched component class ref vs. its RHL-proxied version. The issue was observed with running `<ComposedModal>` in Carbon website's component live demo pane, opening the modal and hitting the close button. Applied a similar fix to `<DatePicker>`. Fixes carbon-design-system#2630.
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit 9b09a46 |
|
Deploy preview for carbon-components-react ready! Built with commit 9b09a46 https://deploy-preview-5929--carbon-components-react.netlify.app |
joshblack
reviewed
Apr 24, 2020
| if (index === 0 && child.type === DatePickerInput) { | ||
| if ( | ||
| index === 0 && | ||
| child.type === React.createElement(DatePickerInput).type |
There was a problem hiding this comment.
Would we have any prop type warnings if we do createElement without required props (I think id in this case)?
There was a problem hiding this comment.
Good catch - Updated.
joshblack
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the issue that comes with unmatched component class ref vs. its RHL-proxied version. The issue was observed with running
<ComposedModal>in Carbon website's component live demo pane, opening the modal and hitting the close button.Applied a similar fix to
<DatePicker>.Fixes #2630.
Changelog
Changed
.typecheck to component class withReact.createElement(ComponentClass).type.Testing / Reviewing
Testing should make sure
<ComposedModal>and<DatePicker>are not broken.