Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(toggle-small): only emit onChange on keyUp if it exists #5931

Merged
merged 4 commits into from
Apr 25, 2020
Merged

fix(toggle-small): only emit onChange on keyUp if it exists #5931

merged 4 commits into from
Apr 25, 2020

Conversation

janhassel
Copy link
Member

Fixes #5930

Changelog

Changed

  • Only emit onChange in onKeyUp handler if onChange is provided

Testing / Reviewing

  1. Re-create test-case given in [ToggleSmall]: Component errors when used with "Enter" key and no onChange is provided #5930
  2. Verify with changes from this PR

@janhassel janhassel requested a review from a team as a code owner April 24, 2020 14:05
@ghost ghost requested review from asudoh and tw15egan April 24, 2020 14:05
@netlify
Copy link

netlify bot commented Apr 24, 2020 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit b7e1b32

https://deploy-preview-5931--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Apr 24, 2020 •
edited
Loading

Deploy preview for carbon-components-react ready!

Built with commit b7e1b32

https://deploy-preview-5931--carbon-components-react.netlify.app

emyarod
emyarod approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

tw15egan
tw15egan approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! 👍 ✅

@asudoh asudoh merged commit 102a6fe into carbon-design-system:master Apr 25, 2020
@janhassel janhassel deleted the toggle-onchange branch April 25, 2020 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod emyarod approved these changes

@tw15egan tw15egan tw15egan approved these changes

@asudoh asudoh Awaiting requested review from asudoh

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ToggleSmall]: Component errors when used with "Enter" key and no onChange is provided
4 participants
@janhassel @emyarod @tw15egan @asudoh