fix(SideNav): detect child node for blur #6043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes fixes a logic in `<SideNav>` where it detects focus on a nav item as side nav losing focus as a whole. Fixes carbon-design-system#6004.
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit 3faaf6a |
|
Deploy preview for carbon-components-react ready! Built with commit 3faaf6a https://deploy-preview-6043--carbon-components-react.netlify.app |
emyarod
approved these changes
May 8, 2020
joshblack
approved these changes
May 12, 2020
aledavila
approved these changes
May 12, 2020
joshblack
pushed a commit
that referenced
this pull request
May 13, 2020
This changes fixes a logic in `<SideNav>` where it detects focus on a nav item as side nav losing focus as a whole. Fixes #6004.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes fixes a logic in
<SideNav>where it detects focus on anav item as side nav losing focus as a whole.
Fixes #6004.
Changelog
Changed
Testing / Reviewing
Testing should make sure side nav is not broken.