fix(button): ensure icons with multiple paths render properly #6230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
tw15egan
requested review from
a team and
jeanservaas
and removed request for
a team
|
Deploy preview for carbon-elements ready! Built with commit 922fa8d |
|
Deploy preview for carbon-components-react ready! Built with commit 922fa8d https://deploy-preview-6230--carbon-components-react.netlify.app |
emyarod
reviewed
Jun 9, 2020
joshblack
approved these changes
Jun 10, 2020
jeanservaas
approved these changes
Jun 11, 2020
emyarod
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6218
Some icons (filled variations) have two paths, which were both getting set to
currentColor.This PR changes our selectors so that we only set the fill on the first
path. I'm unsure if this will work for all icons (do we have icons with more paths that could potentially be in buttons?), but it resolves the linked issue.Changelog
New
Changed
pathelementTesting / Reviewing
Check out all variations of buttons and ensure both
AddandAddFilledrender properly.