Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(FileUploaderItem): add proptypes for size prop #6325

Merged

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Jun 22, 2020

Closes #6322

This PR adds prop type definitions for the size prop in FileUploaderItem

@emyarod emyarod requested a review from a team as a code owner June 22, 2020 23:06
@ghost ghost requested review from joshblack and tw15egan June 22, 2020 23:06
@netlify
Copy link

netlify bot commented Jun 22, 2020

Deploy preview for carbon-elements ready!

Built with commit c666a22

https://deploy-preview-6325--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jun 22, 2020

Deploy preview for carbon-components-react ready!

Built with commit c666a22

https://deploy-preview-6325--carbon-components-react.netlify.app

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @emyarod!

@emyarod emyarod requested a review from a team as a code owner June 23, 2020 14:15
@emyarod emyarod force-pushed the 6322-fileuploaderitem-size-prop branch from 9ecc8ff to c666a22 Compare July 7, 2020 16:23
@emyarod emyarod merged commit 8a284ea into carbon-design-system:master Jul 7, 2020
@emyarod emyarod deleted the 6322-fileuploaderitem-size-prop branch June 10, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File uploader: Missing prop type for size prop
4 participants