docs(Search): clarify label prop requirement #6400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit 5f91f63 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 5f91f63 https://deploy-preview-6400--carbon-components-react.netlify.app |
tw15egan
approved these changes
Jul 7, 2020
joshblack
approved these changes
Jul 9, 2020
joshblack
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6396
This PR clarifies the
labelTextprop description to show the prop is required. Based on the recent changes (autogenerating IDs to connect the label and search input) and the history of the prop type definition (it has been required since the start), it looks like the prop should be required even if it is a hidden label