Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdown,multiselect): add support for refs on buttons #6441

Merged

Conversation

joshblack
Copy link
Contributor

Closes #6228

Changelog

New

Changed

  • Update Dropdown and MultiSelect to accept a ref. This ref is placed on the button of each

Removed

@joshblack joshblack requested review from a team as code owners July 10, 2020 18:51
@ghost ghost requested review from aledavila and emyarod July 10, 2020 18:52
@netlify
Copy link

netlify bot commented Jul 10, 2020

Deploy preview for carbon-elements ready!

Built with commit 35534e8

https://deploy-preview-6441--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 10, 2020

Deploy preview for carbon-components-react ready!

Built with commit 35534e8

https://deploy-preview-6441--carbon-components-react.netlify.app

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link
Contributor

@aledavila aledavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kodiakhq kodiakhq bot merged commit 2485371 into carbon-design-system:master Jul 14, 2020
@joshblack joshblack deleted the 6228-add-refs-to-dropdowns branch July 14, 2020 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown in carbon-components-react@7.13.0 no longer passes ref correctly
3 participants