fix(button): ensure rem in variable definition level #6470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes sure `rem` unit is used in variable definition level (as it's done for other variables). Fixes carbon-design-system#6469.
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit aef68ea |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit aef68ea https://deploy-preview-6470--carbon-components-react.netlify.app |
dakahn
approved these changes
Jul 15, 2020
joshblack
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes sure
remunit is used in variable definition level (as it's done for other variables).Fixes #6469.
Changelog
Changed
$button-heightdefinition to useremunit, as it's done for other variables.button/_mixins.scss.Testing / Reviewing
Testing should make sure our button is not broken.