Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(style): update style guide for component naming #6642

Merged

Conversation

joshblack
Copy link
Contributor

Updates style guide based on feedback from @emyarod during his Tree View PR 👀

Changelog

New

Changed

  • Update style guide for React component to specify that the unstable_ prefix should be on the component export, and not the component itself
  • Migrate unstable pagination code to this scheme

Removed

@joshblack joshblack requested review from a team as code owners August 10, 2020 15:53
@joshblack
Copy link
Contributor Author

joshblack commented Aug 10, 2020

FYI @jendowns in case you were wondering about the Pagination changes 👀 Let me know if you have any questions!

@jendowns
Copy link
Contributor

Thank you @joshblack that makes a lot of sense 👍 No questions here!

@netlify
Copy link

netlify bot commented Aug 10, 2020

Deploy preview for carbon-elements ready!

Built with commit 2f496ee

https://deploy-preview-6642--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Aug 10, 2020

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit 2f496ee

https://deploy-preview-6642--carbon-components-react.netlify.app

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@kodiakhq kodiakhq bot merged commit 4eb5465 into carbon-design-system:master Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants