-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(style): update style guide for component naming #6642
docs(style): update style guide for component naming #6642
Conversation
FYI @jendowns in case you were wondering about the Pagination changes 👀 Let me know if you have any questions! |
Thank you @joshblack that makes a lot of sense 👍 No questions here! |
Deploy preview for carbon-elements ready! Built with commit 2f496ee |
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 2f496ee https://deploy-preview-6642--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 ✅
Updates style guide based on feedback from @emyarod during his Tree View PR 👀
Changelog
New
Changed
unstable_
prefix should be on the component export, and not the component itselfRemoved