fix(button): remove danger ghost icon only button svg margin #7618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emyarod
requested review from
a team and
thyhmdo
and removed request for
a team
|
Deploy preview for carbon-elements ready! Built with commit 8e5d312 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 8e5d312 https://deploy-preview-7618--carbon-components-react.netlify.app |
joshblack
approved these changes
Jan 21, 2021
|
Not introduced in this PR, but I noticed the Danger variant with icons are rendering wrong
|
emyarod
requested review from
laurenmrice,
a team,
andreancardona and
dakahn
and removed request for
thyhmdo and
a team
andreancardona
approved these changes
Jan 22, 2021
emyarod
force-pushed
the
7534-danger-ghost-icon-only-button
branch
from
c0ea410
to
4f90c7d
Compare
laurenmrice
requested changes
Jan 25, 2021
emyarod
force-pushed
the
7534-danger-ghost-icon-only-button
branch
from
4f90c7d
to
4c4978b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7534
This PR fixes support for danger ghost icon only buttons (related #5610)
Changelog
New
Changed
Testing / Reviewing
Confirm the new button kinds are viewable in storybook and the danger ghost icon only button appears correct