-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(TextInput): add displayName so that deprecation warning message is correctly formatted #9460
fix(TextInput): add displayName so that deprecation warning message is correctly formatted #9460
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: a2106b6 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61276e197bda8800072a3b82 😎 Browse the preview: https://deploy-preview-9460--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: a2106b6 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61276e1904b6cc000843e447 😎 Browse the preview: https://deploy-preview-9460--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: a2106b6 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61276e19a63abd0008fc612e 😎 Browse the preview: https://deploy-preview-9460--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this @dcwarwick! This looks good, it just needs the public api snapshot updated via yarn test -u
Public api snapshot updated. I don't know what the percy issues is: this change shouldn't cause any visual change at all, and the difference it flags up doesn't look related. |
Contributes to #9459
This PR adds a
displayName
to theTextInput
component. This fixes the deprecation warning message whenTextInput.PasswordInput
is used from "Warning: The PasswordInput field has been deprecated on the undefined object. Please import and use the field directly." to "Warning: The PasswordInput field has been deprecated on the TextInput object. Please import and use the field directly."Changelog
Changed