-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pictograms): add new cities and new category #9539
feat(pictograms): add new cities and new category #9539
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 8d7aff6 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/612cf492e4213a0007893209 😎 Browse the preview: https://deploy-preview-9539--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 8d7aff6 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/612cf49226b15b00081c6915 😎 Browse the preview: https://deploy-preview-9539--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 8d7aff6 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/612cf4920d176f00079ca538 😎 Browse the preview: https://deploy-preview-9539--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
Closes #
{{closes missing city pictograms from issue #1 and new pictograms from #53}}
Changelog
New
{{
New Category:
Public service
New Pictograms and their (categories): firefighter (Public service)
social--worker (Public service)
teacher (Public service)
police (Public service – moved from Enforcement)
portland--building (Cities)
seoul--gyeongbokgung-palace (Cities)
}}
Changed
Enforcement
category changed toGovernment
andPolice
pictogram moved from oldEnforcement
category to newPublic service
category}}Removed
Testing / Reviewing
{{ These new pictograms, new category and renamed category should appear on both carbon design system site and IBM Design Language site }}