feat(modal): deprecate iconDescription

[sstrubberg]

REF #9624

Added deprecation warnings for iconDescription for v11.

Changelog

• Removed iconDescription from Storybook
• title and aria-label attributes now use the ariaLabel prop instead of iconDescription.
• The close button now gets an aria-hidden="true"
• Removed tests involving iconDescription. Added a new test to ensure the aria-hidden is applied to the Close20 icon.

Testing / Reviewing

Review Modal in Storybook and ensure tests are firing off correctly.

Questions

• Should the aria-label be required now? REF 9466 - thx @abbeyhrt

[netlify]

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 67be21f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61718f885cc8470007c4e0bc

😎 Browse the preview: https://deploy-preview-9828--carbon-react-next.netlify.app

[netlify]

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 67be21f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61718f88512e5300086f0f2b

😎 Browse the preview: https://deploy-preview-9828--carbon-elements.netlify.app

[netlify]

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 67be21f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61718f8851d3b200082a8712

😎 Browse the preview: https://deploy-preview-9828--carbon-components-react.netlify.app

[dakahn]

Looks like its getting flagged in Accessibility Checker for not having a label on the close button. adding aria-label="close" should fix this 👍🏾

[dakahn]

glorious work

[dakahn]

looks good to me 🏄🏾

[aledavila]

lgtm just looks like you need to update snapshots