fix(spacing): spacing issues with ImageCard, list items, and captions #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/carbon-design-system/gatsby-theme-carbon/dm8b08wft |
ghost
requested review from
sstrubberg and
vpicone
and removed request for
a team
|
cc: @peter-garvin, I couldn't request your review, but there's an example of nested content within a list item in the markdown page for you to review. |
jnm2377
commented
Nov 20, 2019
packages/gatsby-theme-carbon/src/components/markdown/Markdown.module.scss
Outdated
Show resolved
Hide resolved
vpicone
requested changes
Nov 20, 2019
packages/gatsby-theme-carbon/src/components/markdown/Markdown.module.scss
Outdated
Show resolved
Hide resolved
packages/gatsby-theme-carbon/src/components/markdown/Markdown.module.scss
Outdated
Show resolved
Hide resolved
packages/gatsby-theme-carbon/src/components/markdown/Markdown.module.scss
Outdated
Show resolved
Hide resolved
packages/gatsby-theme-carbon/src/components/markdown/Markdown.module.scss
Outdated
Show resolved
Hide resolved
|
@jnm2377 spacing looks good to me! |
vpicone
reviewed
Nov 21, 2019
packages/gatsby-theme-carbon/src/components/ImageCard/image-card.scss
Outdated
Show resolved
Hide resolved
…rd.scss Co-Authored-By: Vince Picone <vpicone@gmail.com>
vpicone
approved these changes
Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #505 - image captions
Closes #520 - content within nested lists
Closes #513 - image card vertical spacing bug
Closes #508 - h4 spacing bug
Changelog
New
added temporary example for it for design review (will remove once it's approved)Changed
Reviewers