Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: update list classes to carbon classes #221

Merged
merged 7 commits into from
Jul 11, 2019
Merged

Refactor: update list classes to carbon classes #221

merged 7 commits into from
Jul 11, 2019

Conversation

abbeyhrt
Copy link
Contributor

@abbeyhrt abbeyhrt commented Jul 9, 2019

Closes #191

Changed

  • imports classes for lists from carbon components
  • updates unordered and ordered lists to have carbon class names

New

  • creates Li file so list items will have the appropriate class in markdown
    • list items check and see if they have children that are lists and add the class bx--list--nested to the child if so.

Removed

  • removes styles we had in place for lists since it's no longer needed

Testing

You can see the changes here: https://gatsby-theme-carbon-git-fork-abbeyhrt-chore-update-list-classes.carbon-design-system.now.sh/components/markdown in the section under list

Here's what it looked like before:
Screen Shot 2019-07-09 at 3 12 39 PM

and now:
Screen Shot 2019-07-09 at 3 15 22 PM

@vercel
Copy link

vercel bot commented Jul 9, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://gatsby-theme-carbon-git-fork-abbeyhrt-chore-update-list-classes.carbon-design-system.now.sh

@abbeyhrt abbeyhrt changed the title Chore update list classes Refactor: update list classes to carbon classes Jul 9, 2019
@abbeyhrt abbeyhrt requested review from vpicone and alisonjoseph and removed request for vpicone July 9, 2019 19:36
Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@abbeyhrt abbeyhrt merged commit c056fe0 into carbon-design-system:master Jul 11, 2019
@abbeyhrt abbeyhrt deleted the chore-update-list-classes branch July 11, 2019 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use list classes from Carbon
2 participants