fix(Switcher): change width and border-bottom #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://gatsby-theme-carbon-git-fork-abbeyhrt-357-fix-switcher-px-off.carbon-design-system.now.sh |
vpicone
requested changes
Aug 27, 2019
| @@ -3,14 +3,14 @@ | |||
| z-index: 10000; | |||
| position: fixed; | |||
| right: 0; | |||
| top: 48px; | |||
| top: 47px; | |||
There was a problem hiding this comment.
Usually if we get into pixel nudging like this, there's a better solution somewhere. Doing this approach means we don't get the border-top like we want.
There was a problem hiding this comment.
Ah that makes sense! Made the change!
| height: 100%; | ||
| width: 16rem; | ||
| background-color: $ui-05; | ||
| border-left: 1px solid $inverse-02; | ||
| transform: translateX(16rem); | ||
| overflow-y: hidden; | ||
| border-bottom: 1px solid transparent; | ||
| border-bottom: 1px solid $inverse-02; |
There was a problem hiding this comment.
Try leaving the top rule at 48px and just removing this border-bottom rule all together. That way the border will just appear instantly once the open class gets applied.
vpicone
approved these changes
Aug 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #357
48pxto47pxtp remove the 1px overhangTesting: check that the Switcher is no longer 1 px off and that the border matches the rest of the nav bar