fix(CreateFullPage): header height to work properly on older browsers #5993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baraaabdelsalam
requested review from
elycheea and
makafsal
and removed request for
a team
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
baraaabdelsalam
force-pushed
the
bug/id-5992
branch
from
28cc0ca
to
f09bc26
Compare
makafsal
approved these changes
Sep 9, 2024
amal-k-joy
requested changes
Sep 10, 2024
| } | ||
| .c4p--create-full-page:has(.c4p--create-full-page__header) { | ||
| grid-template-rows: auto minmax(auto, 100%); | ||
| grid-template-rows: auto minmax(min-content, 100%); |
There was a problem hiding this comment.
Hey @baraaabdelsalam ,
Looks like there is a height/scroll issue with this change. At smaller viewport heights, the footer buttons section need to be fixed and inner content has to scrollable which is not happening now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5992
Fixes the header height issues that showed up in some older browsers
What did you change?
Modify some CSS code to ensure broader compatibility
How did you test and verify your work?
Manually on different browsers on MacOS