fix: Resolve all typescript errors #6013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
makafsal
changed the title
makafsal
changed the title
makafsal
requested review from
matthewgallo and
AlexanderMelox
and removed request for
a team
AlexanderMelox
requested changes
Sep 10, 2024
packages/ibm-products/src/components/CreateInfluencer/CreateInfluencer.tsx
Outdated
Show resolved
Hide resolved
packages/ibm-products/src/components/CreateModal/CreateModal.tsx
Outdated
Show resolved
Hide resolved
matthewgallo
reviewed
Oct 1, 2024
packages/ibm-products/src/components/UserProfileImage/UserProfileImage.tsx
Outdated
Show resolved
Hide resolved
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@makafsal Mend security checks are failing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6013 +/- ##
==========================================
- Coverage 78.71% 78.68% -0.03%
==========================================
Files 395 395
Lines 12849 12851 +2
Branches 4248 4252 +4
==========================================
- Hits 10114 10112 -2
- Misses 2735 2739 +4
|
matthewgallo
approved these changes
Oct 28, 2024
davidmenendez
approved these changes
Oct 30, 2024
Merged
via the queue into
carbon-design-system:main
with commit Nov 4, 2024
e87db88
30 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5945
This resolves many typescript issues including #5945
What did you change?
Fixed typescript errors across all components
How did you test and verify your work?
yarn avtyarn test