Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DataGrid): disable save button on customise column #6026

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

amal-k-joy
Copy link
Contributor

Closes #5843

If all the columns are unchecked, Save button should not be enabled in Datagrid customise columns

How did you test and verify your work?

storybook

@amal-k-joy amal-k-joy requested a review from a team as a code owner September 10, 2024 04:59
@amal-k-joy amal-k-joy requested review from elycheea and anamikaanu96 and removed request for a team September 10, 2024 04:59
Copy link

netlify bot commented Sep 10, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 003a520
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/66ec0c21a44562000810078b
😎 Deploy Preview https://deploy-preview-6026--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

anamikaanu96
anamikaanu96 previously approved these changes Sep 17, 2024
Copy link
Contributor

@anamikaanu96 anamikaanu96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@davidmenendez davidmenendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. just one additional request. please include a unit test to verify the functionality. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CUSTOMIZE COLUMNS BUG]: If all the columns are unchecked, Save button should not be enabled
3 participants