feat(tagset): support for size on overflow tag #6065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
devadula-nandan
requested review from
davidmenendez and
sangeethababu9223
and removed request for
a team
davidmenendez
requested changes
Sep 18, 2024
| @@ -124,6 +124,8 @@ $block-class-modal: #{$_block-class}-modal; | |||
| } | |||
|
|
|||
| .#{$block-class-overflow}__popover-trigger { | |||
| /* stylelint-disable-next-line declaration-no-important */ | |||
| border: none !important; | |||
There was a problem hiding this comment.
weird. i don't see this change showing up in the deploy preview. what is this doing? just curious because of the important usage.
There was a problem hiding this comment.
hey @davidmenendez,
The OperationalTag from Carbon has a default border, so I have added this override to match our design.
There was a problem hiding this comment.
it looks like this without the override
davidmenendez
approved these changes
Sep 19, 2024
sangeethababu9223
approved these changes
Sep 20, 2024
Merged
via the queue into
carbon-design-system:main
with commit Sep 20, 2024
ba29c09
21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5923
adds support to add sizes on overflow tag, and changes the
TagSetOverflowto useOperationalTag.now the overflow tag takes the size of the last tag. if the size is not passed to the the tags, it will default to
mdWhat did you change?
packages/ibm-products/src/components/TagSet/TagSet.tsx
packages/ibm-products/src/components/TagSet/TagSetOverflow.tsx
How did you test and verify your work?
storybook